Skip to main content

puppetlabs-pe_status_check fails with a Facter error in Puppet Enterprise

Marty Ewings
  • Updated

When you use the puppetlabs-pe_status_check module, installed by default in Puppet Enterprise (PE) 2021.7 and later, it fails with a Facter error resolving the pe_status_check fact.

Error messages and logs

[2022-10-06 17:07:13.448508 ] ERROR Facter - [31mError while resolving custom fact fact='pe_status_check', resolution='<anonymous>': invalid date or strptime format - `[06/Oct./2022:11:12:21 +1100]' `[%d/%b/%Y:%H:%M:%S %Z]'[0m

When Puppet services are started on infrastructure nodes with non-US or non-UK English locales, for example, en-AU, it causes errors in Apache logging and parsing in the Puppet Server access log. The time the request was made outputs <MONTH>. (with a dot at the end) instead of <MONTH>. For example:

[07/Oct./2022:11:25:25 +0000] "POST /metrics/v2

This is not a valid date string or strptime format. The formatting error breaks log parsing, causing pe_status_check to fail with a Facter error.

Version and installation information

PE version: All supported

Solution

To reduce the error to a warning and allow facts to resolve, update to the latest version of the pe_status_check module manually using the instructions in the module’s README.

Did this solve your problem?
0 out of 1 found this helpful

How can we improve this article?

2 comments

Date Votes
  • Dinan Yin

    After upgrading the module to the latest 2.6.0, the error doesn't affect the entire custom fact, however I'm still getting it as a warning:

    Warning: Facter: Error in fact 'pe_status_check.S0039' when querying puppetserver access logs: invalid date or strptime format - `[08/Mar./2023:00:00:00 +1100]' `[%d/%b/%Y:%H:%M:%S %Z]'

    The issue seems to be `strptime` in the S0039 chunk:

      chunk(:S0039) do
        # PuppetServer
        next unless ['primary', 'legacy_primary', 'replica', 'pe_compiler', 'legacy_compiler'].include?(Facter.value('pe_status_check_role'))

        logfile = File.dirname(Puppet.settings['logdir'].to_s) + '/puppetserver/puppetserver-access.log'
        apache_regex = %r{^(\S+) \S+ (\S+) (?<time>\[([^\]]+)\]) "([A-Z]+) ([^ "]+)? HTTP/[0-9.]+" (?<status>[0-9]{3})}

        has_503 = File.foreach(logfile).any? do |line|
          match = line.match(apache_regex)
          next unless match && match[:time] && match[:status]

          time = Time.strptime(match[:time], '[%d/%b/%Y:%H:%M:%S %Z]')
          since_lastrun = Time.now - time
          current = since_lastrun.to_i <= Puppet.settings['runinterval']

          match[:status] == '503' and current
        rescue StandardError => e
          Facter.warn("Error in fact 'pe_status_check.S0039' when querying puppetserver access logs: #{e.message}")
          Facter.debug(e.backtrace)
          break
        end

        { S0039: !has_503 }
      end

    0
  • DeLeon DeMicoli

    Hi Dinan,

    I see you submitted a ticket with support. A support engineer will get back to you soon.

    Thanks!

    0

Please sign in to leave a comment.

Related articles